Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-22.2: roachprod: fix regression in propagateDiskLabels #103210

Merged
merged 1 commit into from
May 12, 2023
Merged

release-22.2: roachprod: fix regression in propagateDiskLabels #103210

merged 1 commit into from
May 12, 2023

Conversation

srosenberg
Copy link
Member

@srosenberg srosenberg commented May 12, 2023 •
edited
Loading

Backport 1/1 commits from #103191.

/cc @cockroachdb/release

Previous PR [1] fixed data races, and as a result of refactoring, introduced another bug.
When multiple zones are used, the --zone arg. is duplicated across all hosts.

Epic: none
Release note: None
Release justification: CI/test only change

[1] #103087

@srosenberg
roachprod: fix regression in propagateDiskLabels
32df452 
Previous PR [1] fixed data races, and as a result of
refactoring, introduced another bug.
When multiple zones are used, the `--zone` arg. is
duplicated across all hosts.

Epic: none
Release note: None

[1] cockroachdb#103087
@srosenberg srosenberg requested a review from a team as a code owner May 12, 2023 16:51
@srosenberg srosenberg requested review from smg260 and renatolabs and removed request for a team May 12, 2023 16:51
@blathers-crl
Copy link

blathers-crl bot commented May 12, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@srosenberg srosenberg merged commit 0d8f5be into cockroachdb:release-22.2 May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renatolabs renatolabs renatolabs approved these changes

@smg260 smg260 Awaiting requested review from smg260 smg260 is a code owner automatically assigned from cockroachdb/test-eng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@srosenberg @cockroach-teamcity @renatolabs